Commit fd4e1393 authored Jul 06, 2015 by Nicholas Mc Guire Committed by Nicholas Bellinger Jul 23, 2015

tcm_qla2xxx: pass timeout as HZ independent value



API compliance scanning with coccinelle flagged:
./drivers/scsi/qla2xxx/tcm_qla2xxx.c:407:2-29:
         WARNING: timeout is HZ dependent

This was introduced in 'commit 75f8c1f6 ("[SCSI] tcm_qla2xxx: Add >=
24xx series fabric module for target-core")'. wait_for_completion_timeout()
expects a timeout in jiffies so the numeric constant makes the effective
timeout HZ dependent. Resolved by converting it to CONST * HZ.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Nilesh Javali <nilesh.javali@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 5dacbfc9

drivers/scsi/qla2xxx/tcm_qla2xxx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -405,7 +405,7 @@ static int tcm_qla2xxx_write_pending_status(struct se_cmd *se_cmd)
		se_cmd->t_state == TRANSPORT_COMPLETE_QF_WP) {
		spin_unlock_irqrestore(&se_cmd->t_state_lock, flags);
		wait_for_completion_timeout(&se_cmd->t_transport_stop_comp,
		3000);
		3 * HZ);
		return 0;
		}
		spin_unlock_irqrestore(&se_cmd->t_state_lock, flags);

Admin message