Commit fd315da5 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Greg Kroah-Hartman
Browse files

staging: comedi: mite: Replace function mite_request_channel_in_range() 



Remove function mite_request_channel_in_range as all it does is call
__mite_request_channel.
Rename __mite_request_channel to mite_request_channel_in_range and
change its type from static to non-static to maintain compatibility with
call sites.
Change only remaining call site of __mite_request_channel to call
mite_request_channel_in_range_instead.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20190701070025.3838-3-nishkadg.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 931282a9

drivers/staging/comedi/drivers/mite.c

+10 −17
Original line number Diff line number Diff line
@@ -558,7 +558,14 @@ void mite_prep_dma(struct mite_channel *mite_chan, 
}

EXPORT_SYMBOL_GPL(mite_prep_dma);



static struct mite_channel *__mite_request_channel(struct mite *mite,

/**

 * mite_request_channel_in_range() - Request a MITE dma channel.

 * @mite: MITE device.

 * @ring: MITE dma ring.

 * @min_channel: minimum channel index to use.

 * @max_channel: maximum channel index to use.

 */

struct mite_channel *mite_request_channel_in_range(struct mite *mite,

						   struct mite_ring *ring,

						   unsigned int min_channel,

						   unsigned int max_channel)
@@ -583,21 +590,6 @@ static struct mite_channel *__mite_request_channel(struct mite *mite, 
	spin_unlock_irqrestore(&mite->lock, flags);

	return mite_chan;

}



/**

 * mite_request_channel_in_range() - Request a MITE dma channel.

 * @mite: MITE device.

 * @ring: MITE dma ring.

 * @min_channel: minimum channel index to use.

 * @max_channel: maximum channel index to use.

 */

struct mite_channel *mite_request_channel_in_range(struct mite *mite,

						   struct mite_ring *ring,

						   unsigned int min_channel,

						   unsigned int max_channel)

{

	return __mite_request_channel(mite, ring, min_channel, max_channel);

}

EXPORT_SYMBOL_GPL(mite_request_channel_in_range);



/**
@@ -608,7 +600,8 @@ EXPORT_SYMBOL_GPL(mite_request_channel_in_range); 
struct mite_channel *mite_request_channel(struct mite *mite,

					  struct mite_ring *ring)

{

	return __mite_request_channel(mite, ring, 0, mite->num_channels - 1);

	return mite_request_channel_in_range(mite, ring, 0,

					     mite->num_channels - 1);

}

EXPORT_SYMBOL_GPL(mite_request_channel);

CRA Git | Maintained and supported by SUSTech CRA and CCSE