Commit fd2d180a authored Jul 22, 2016 by Xin Long Committed by David S. Miller Jul 25, 2016

sctp: use inet_recvmsg to support sctp RFS well



Commit 486bdee0 ("sctp: add support for RPS and RFS")
saves skb->hash into sk->sk_rxhash so that the inet_* can
record it to flow table.

But sctp uses sock_common_recvmsg as .recvmsg instead
of inet_recvmsg, sock_common_recvmsg doesn't invoke
sock_rps_record_flow to record the flow. It may cause
that the receiver has no chances to record the flow if
it doesn't send msg or poll the socket.

So this patch fixes it by using inet_recvmsg as .recvmsg
in sctp.

Fixes: 486bdee0 ("sctp: add support for RPS and RFS")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 07a01697

net/sctp/ipv6.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -956,7 +956,7 @@ static const struct proto_ops inet6_seqpacket_ops = {
		.setsockopt = sock_common_setsockopt,
		.getsockopt = sock_common_getsockopt,
		.sendmsg = inet_sendmsg,
		.recvmsg = sock_common_recvmsg,
		.recvmsg = inet_recvmsg,
		.mmap = sock_no_mmap,
		#ifdef CONFIG_COMPAT
		.compat_setsockopt = compat_sock_common_setsockopt,

net/sctp/protocol.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1028,7 +1028,7 @@ static const struct proto_ops inet_seqpacket_ops = {
		.setsockopt = sock_common_setsockopt, /* IP_SOL IP_OPTION is a problem */
		.getsockopt = sock_common_getsockopt,
		.sendmsg = inet_sendmsg,
		.recvmsg = sock_common_recvmsg,
		.recvmsg = inet_recvmsg,
		.mmap = sock_no_mmap,
		.sendpage = sock_no_sendpage,
		#ifdef CONFIG_COMPAT

Admin message