Commit fd250a66 authored by Sam Ravnborg's avatar Sam Ravnborg Committed by David S. Miller
Browse files

sparc: fix sparse warnings in cpu.c 



Fix following sparc32 warning:
cpu.c:430:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?

Fix following sparc64 warnings:
cpu.c:364:14: warning: symbol 'dcache_parity_tl1_occurred' was not declared. Should it be static?
cpu.c:365:14: warning: symbol 'icache_parity_tl1_occurred' was not declared. Should it be static?

Rearrange asm/cpu.h to share more stuff between sparc32 and sparc64.
Added missing include to cpu.c of kernel.h

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c8ee361

arch/sparc/include/asm/cpudata.h

+10 −0
Original line number Diff line number Diff line 
#ifndef ___ASM_SPARC_CPUDATA_H

#define ___ASM_SPARC_CPUDATA_H



#ifndef __ASSEMBLY__



#include <linux/threads.h>

#include <linux/percpu.h>



extern const struct seq_operations cpuinfo_op;



#endif /* !(__ASSEMBLY__) */



#if defined(__sparc__) && defined(__arch64__)

#include <asm/cpudata_64.h>

#else

arch/sparc/include/asm/cpudata_64.h

+0 −5
Original line number Diff line number Diff line
@@ -8,9 +8,6 @@ 


#ifndef __ASSEMBLY__



#include <linux/percpu.h>

#include <linux/threads.h>



typedef struct {

	/* Dcache line 1 */

	unsigned int	__softirq_pending; /* must be 1st, see rtrap.S */
@@ -35,8 +32,6 @@ DECLARE_PER_CPU(cpuinfo_sparc, __cpu_data); 
#define cpu_data(__cpu)		per_cpu(__cpu_data, (__cpu))

#define local_cpu_data()	__get_cpu_var(__cpu_data)



extern const struct seq_operations cpuinfo_op;



#endif /* !(__ASSEMBLY__) */



#include <asm/trap_block.h>

arch/sparc/kernel/cpu.c

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include <asm/cpudata.h>



#include "kernel.h"

#include "entry.h"



DEFINE_PER_CPU(cpuinfo_sparc, __cpu_data) = { 0 };

EXPORT_PER_CPU_SYMBOL(__cpu_data);

CRA Git | Maintained and supported by SUSTech CRA and CCSE