Commit fd1a52f3 authored by Markus Elfring's avatar Markus Elfring Committed by Jason Gunthorpe
Browse files

RDMA/iwpm: Delete unnecessary checks before the macro call "dev_kfree_skb" 

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Link: https://lore.kernel.org/r/16df4c50-1f61-d7c4-3fc8-3073666d281d@web.de


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 1bc5ba83

drivers/infiniband/core/iwpm_msg.c

+3 −6
Original line number Diff line number Diff line
@@ -124,7 +124,6 @@ int iwpm_register_pid(struct iwpm_dev_data *pm_msg, u8 nl_client) 
	return ret;

pid_query_error:

	pr_info("%s: %s (client = %d)\n", __func__, err_str, nl_client);

	if (skb)

	dev_kfree_skb(skb);

	if (nlmsg_request)

		iwpm_free_nlmsg_request(&nlmsg_request->kref);
@@ -214,7 +213,6 @@ int iwpm_add_mapping(struct iwpm_sa_data *pm_msg, u8 nl_client) 
add_mapping_error:

	pr_info("%s: %s (client = %d)\n", __func__, err_str, nl_client);

add_mapping_error_nowarn:

	if (skb)

	dev_kfree_skb(skb);

	if (nlmsg_request)

		iwpm_free_nlmsg_request(&nlmsg_request->kref);
@@ -308,7 +306,6 @@ int iwpm_add_and_query_mapping(struct iwpm_sa_data *pm_msg, u8 nl_client) 
query_mapping_error:

	pr_info("%s: %s (client = %d)\n", __func__, err_str, nl_client);

query_mapping_error_nowarn:

	if (skb)

	dev_kfree_skb(skb);

	if (nlmsg_request)

		iwpm_free_nlmsg_request(&nlmsg_request->kref);

drivers/infiniband/core/iwpm_util.c

+3 −6
Original line number Diff line number Diff line
@@ -655,7 +655,6 @@ static int send_mapinfo_num(u32 mapping_num, u8 nl_client, int iwpm_pid) 
	return 0;

mapinfo_num_error:

	pr_info("%s: %s\n", __func__, err_str);

	if (skb)

	dev_kfree_skb(skb);

	return ret;

}
@@ -778,7 +777,6 @@ send_mapping_info_unlock: 
send_mapping_info_exit:

	if (ret) {

		pr_warn("%s: %s (ret = %d)\n", __func__, err_str, ret);

		if (skb)

		dev_kfree_skb(skb);

		return ret;

	}
@@ -834,7 +832,6 @@ int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version) 
	return 0;

hello_num_error:

	pr_info("%s: %s\n", __func__, err_str);

	if (skb)

	dev_kfree_skb(skb);

	return ret;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE