Commit fd15dd05 authored Oct 07, 2020 by Johannes Berg Committed by Jakub Kicinski Oct 08, 2020

ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET



This accidentally got wired up to the *get* policy instead
of the *set* policy, causing operations to be rejected. Fix
it by wiring up the correct policy instead.

Fixes: 5028588b ("ethtool: wire up set policies to ops")
Reported-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent db972e53

net/ethtool/netlink.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -830,8 +830,8 @@ static const struct genl_ops ethtool_genl_ops[] = {
		.cmd = ETHTOOL_MSG_CHANNELS_SET,
		.flags = GENL_UNS_ADMIN_PERM,
		.doit = ethnl_set_channels,
		.policy = ethnl_channels_get_policy,
		.maxattr = ARRAY_SIZE(ethnl_channels_get_policy) - 1,
		.policy = ethnl_channels_set_policy,
		.maxattr = ARRAY_SIZE(ethnl_channels_set_policy) - 1,
		},
		{
		.cmd = ETHTOOL_MSG_COALESCE_GET,

Admin message