Commit fd143b21 authored Sep 05, 2014 by Andy Lutomirski Committed by H. Peter Anvin Sep 08, 2014

x86, entry: Only call user_exit if TIF_NOHZ



The RCU context tracking code requires that arch code call
user_exit() on any entry into kernel code if TIF_NOHZ is set.  This
patch adds a check for TIF_NOHZ and a comment to the syscall entry
tracing code.

The main purpose of this patch is to make the code easier to follow:
one can read the body of user_exit and of every function it calls
without finding any explanation of why it's called for traced
syscalls but not for untraced syscalls.  This makes it clear when
user_exit() is necessary.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/0b13e0e24ec0307d67ab7a23b58764f6b1270116.1409954077.git.luto@amacapital.net


Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

parent 81f49a8f

arch/x86/kernel/ptrace.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1449,6 +1449,11 @@ long syscall_trace_enter(struct pt_regs *regs)
		{
		long ret = 0;

		/*
		* If TIF_NOHZ is set, we are required to call user_exit() before
		* doing anything that could touch RCU.
		*/
		if (test_thread_flag(TIF_NOHZ))
		user_exit();

		/*

Admin message