staging: sep: Fix sign of error (fcff311c) · Commits · 戴 / test

One of our errors wasn't negative as intended. Fix this. (Found by Hillf Danton) While we are at it turn user causable messages down to dev_dbg level in the ioctl paths. Signed-off-by:

Alan Cox <alan@linux.intel.com> Cc: stable <stable@vger.kernel.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/sep/sep_main.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -3114,7 +3114,7 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		current->pid);
		if (1 == test_bit(SEP_LEGACY_SENDMSG_DONE_OFFSET,
		&call_status->status)) {
		dev_warn(&sep->pdev->dev,
		dev_dbg(&sep->pdev->dev,
		"[PID%d] dcb prep needed before send msg\n",
		current->pid);
		error = -EPROTO;
		@@ -3122,9 +3122,9 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		}

		if (!arg) {
		dev_warn(&sep->pdev->dev,
		dev_dbg(&sep->pdev->dev,
		"[PID%d] dcb null arg\n", current->pid);
		error = EINVAL;
		error = -EINVAL;
		goto end_function;
		}

Admin message