Commit fce55922 authored Apr 13, 2011 by Allan, Bruce W Committed by David S. Miller Apr 14, 2011

ethtool: allow custom interval for physical identification



When physical identification of an adapter is done by toggling the
mechanism on and off through software utilizing the set_phys_id operation,
it is done with a fixed duration for both on and off states.  Some drivers
may want to set a custom duration for the on/off intervals.  This patch
changes the API so the return code from the driver's entry point when it
is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
cycle the on/off states, and updates the drivers that have already been
converted to use the new set_phys_id and use the synchronous method for
identifying an adapter.

The physical identification frequency set in the updated drivers is based
on how it was done prior to the introduction of set_phys_id.

Compile tested only.  Also fixes a compiler warning in sfc.

v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
v3: fold patchset into single patch and cleanup per Ben's feedback

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Cc: Michael Chan <mchan@broadcom.com>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: Divy Le Ray <divy@chelsio.com>
Cc: Don Fry <pcnet32@frontier.com>
Cc: Jon Mason <jdmason@kudzu.us>
Cc: Solarflare linux maintainers <linux-net-drivers@solarflare.com>
Cc: Steve Hodgson <shodgson@solarflare.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Matt Carlson <mcarlson@broadcom.com>
Acked-by: Jon Mason <jdmason@kudzu.us>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 21d8c49e

drivers/net/benet/be_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -516,7 +516,7 @@ be_set_phys_id(struct net_device *netdev,
		case ETHTOOL_ID_ACTIVE:
		be_cmd_get_beacon_state(adapter, adapter->hba_port_num,
		&adapter->beacon_state);
		return -EINVAL;
		return 1; /* cycle on/off once per second */

		case ETHTOOL_ID_ON:
		be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,

drivers/net/bnx2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7473,7 +7473,7 @@ bnx2_set_phys_id(struct net_device *dev, enum ethtool_phys_id_state state)

		bp->leds_save = REG_RD(bp, BNX2_MISC_CFG);
		REG_WR(bp, BNX2_MISC_CFG, BNX2_MISC_CFG_LEDMODE_MAC);
		return -EINVAL;
		return 1; /* cycle on/off once per second */

		case ETHTOOL_ID_ON:
		REG_WR(bp, BNX2_EMAC_LED, BNX2_EMAC_LED_OVERRIDE \|

drivers/net/bnx2x/bnx2x_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2025,7 +2025,7 @@ static int bnx2x_set_phys_id(struct net_device *dev,

		switch (state) {
		case ETHTOOL_ID_ACTIVE:
		return -EINVAL;
		return 1; /* cycle on/off once per second */

		case ETHTOOL_ID_ON:
		bnx2x_set_led(&bp->link_params, &bp->link_vars,

drivers/net/cxgb3/cxgb3_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1757,7 +1757,7 @@ static int set_phys_id(struct net_device *dev,

		switch (state) {
		case ETHTOOL_ID_ACTIVE:
		return -EINVAL;
		return 1; /* cycle on/off once per second */

		case ETHTOOL_ID_OFF:
		t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL, 0);

drivers/net/ewrk3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1618,7 +1618,7 @@ static int ewrk3_set_phys_id(struct net_device *dev,
		/* Prevent ISR from twiddling the LED */
		lp->led_mask = 0;
		spin_unlock_irq(&lp->hw_lock);
		return -EINVAL;
		return 2; /* cycle on/off twice per second */

		case ETHTOOL_ID_ON:
		cr = inb(EWRK3_CR);

Admin message