Commit fcdb84cc authored Jun 30, 2020 by Cengiz Can Committed by Daniel Thompson Sep 08, 2020

kdb: remove unnecessary null check of dbg_io_ops



`kdb_msg_write` operates on a global `struct kgdb_io *` called
`dbg_io_ops`.

It's initialized in `debug_core.c` and checked throughout the debug
flow.

There's a null check in `kdb_msg_write` which triggers static analyzers
and gives the (almost entirely wrong) impression that it can be null.

Coverity scanner caught this as CID 1465042.

I have removed the unnecessary null check and eliminated false-positive
forward null dereference warning.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Link: https://lore.kernel.org/r/20200630082922.28672-1-cengiz@kernel.wtf


Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

parent f75aef39

kernel/debug/kdb/kdb_io.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -545,19 +545,19 @@ static int kdb_search_string(char searched, char searchfor)
		static void kdb_msg_write(const char *msg, int msg_len)
		{
		struct console *c;
		const char *cp;
		int len;

		if (msg_len == 0)
		return;

		if (dbg_io_ops) {
		const char *cp = msg;
		int len = msg_len;
		cp = msg;
		len = msg_len;

		while (len--) {
		dbg_io_ops->write_char(*cp);
		cp++;
		}
		}

		for_each_console(c) {
		if (!(c->flags & CON_ENABLED))

Admin message