Commit fcd38ed0 authored Jul 27, 2014 by Michal Nazarewicz Committed by Rusty Russell Jul 27, 2014

scripts: modpost: fix compilation warning

The scripts/mod/modpost.c triggers the following warning:

scripts/mod/modpost.c: In function ‘remove_dot’:
scripts/mod/modpost.c:1710:10: warning: ignoring return value of ‘strtoul’, declared with attribute warn_unused_result [-Wunused-result]

The remove_dot function that calls strtoul does not care about the
numeric value of the string that is parsed but only looks for the
end of the numeric sequence. As such, it's equivalent to just skip
over all digits.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 37549e94

scripts/mod/modpost.c

+4 −5

Original line number	Original line	Diff line number	Diff line
	@@ -1703,12 +1703,11 @@ static void check_sec_ref(struct module mod, const char modname,

	static char remove_dot(char s)		static char remove_dot(char s)
	{		{
	char *end;		size_t n = strcspn(s, ".");
	int n = strcspn(s, ".");

	if (n > 0 && s[n] != 0) {		if (n && s[n]) {
	strtoul(s + n + 1, &end, 10);		size_t m = strspn(s + n + 1, "0123456789");
	if (end > s + n + 1 && (end == '.' \|\| end == 0))		if (m && (s[n + m] == '.' \|\| s[n + m] == 0))
	s[n] = 0;		s[n] = 0;
	}		}
	return s;		return s;

Admin message