Commit fcd13f42 authored Mar 24, 2011 by Eric Dumazet Committed by David S. Miller Mar 24, 2011

ipv4: fix fib metrics



Alessandro Suardi reported that we could not change route metrics :

ip ro change default .... advmss 1400

This regression came with commit 9c150e82 (Allocate fib metrics
dynamically). fib_metrics is no longer an array, but a pointer to an
array.

Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Alessandro Suardi <alessandro.suardi@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6f71d792

net/ipv4/fib_semantics.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -251,7 +251,7 @@ static struct fib_info fib_find_info(const struct fib_info nfi)
		nfi->fib_prefsrc == fi->fib_prefsrc &&
		nfi->fib_priority == fi->fib_priority &&
		memcmp(nfi->fib_metrics, fi->fib_metrics,
		sizeof(fi->fib_metrics)) == 0 &&
		sizeof(u32) * RTAX_MAX) == 0 &&
		((nfi->fib_flags ^ fi->fib_flags) & ~RTNH_F_DEAD) == 0 &&
		(nfi->fib_nhs == 0 \|\| nh_comp(fi, nfi) == 0))
		return fi;

Admin message