Commit fcca747f authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

net: aquantia: reject all unsupported coalescing params 



Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver only rejected some of the unsupported parameters.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8e4f90ca

drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c

+3 −12
Original line number Diff line number Diff line
@@ -386,21 +386,10 @@ static int aq_ethtool_set_coalesce(struct net_device *ndev, 


	cfg = aq_nic_get_cfg(aq_nic);



	/* This is not yet supported

	 */

	if (coal->use_adaptive_rx_coalesce || coal->use_adaptive_tx_coalesce)

		return -EOPNOTSUPP;



	/* Atlantic only supports timing based coalescing

	 */

	if (coal->rx_max_coalesced_frames > 1 ||

	    coal->rx_coalesce_usecs_irq ||

	    coal->rx_max_coalesced_frames_irq)

		return -EOPNOTSUPP;



	if (coal->tx_max_coalesced_frames > 1 ||

	    coal->tx_coalesce_usecs_irq ||

	    coal->tx_max_coalesced_frames_irq)

	    coal->tx_max_coalesced_frames > 1)

		return -EOPNOTSUPP;



	/* We do not support frame counting. Check this
@@ -742,6 +731,8 @@ static int aq_ethtool_set_priv_flags(struct net_device *ndev, u32 flags) 
}



const struct ethtool_ops aq_ethtool_ops = {

	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |

				     ETHTOOL_COALESCE_MAX_FRAMES,

	.get_link            = aq_ethtool_get_link,

	.get_regs_len        = aq_ethtool_get_regs_len,

	.get_regs            = aq_ethtool_get_regs,

CRA Git | Maintained and supported by SUSTech CRA and CCSE