ALSA: dice: enclose identifiers referred by single function (fcbe08d4) · Commits · 戴 / test

Some identifiers are referred just by one functions. In this case, they can be put into the function definition. This brings two merits; readers can easily follow codes related to the identifiers, developers are free from name conflict. This commit moves such identifiers to each function definition. Signed-off-by:

Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/firewire/dice/dice-midi.c

+10 −12

Original line number	Diff line number	Diff line
		@@ -78,18 +78,6 @@ static void midi_playback_trigger(struct snd_rawmidi_substream *substrm, int up)
		spin_unlock_irqrestore(&dice->lock, flags);
		}

		static struct snd_rawmidi_ops capture_ops = {
		.open = midi_open,
		.close = midi_close,
		.trigger = midi_capture_trigger,
		};

		static struct snd_rawmidi_ops playback_ops = {
		.open = midi_open,
		.close = midi_close,
		.trigger = midi_playback_trigger,
		};

		static void set_midi_substream_names(struct snd_dice *dice,
		struct snd_rawmidi_str *str)
		{
		@@ -103,6 +91,16 @@ static void set_midi_substream_names(struct snd_dice *dice,

		int snd_dice_create_midi(struct snd_dice *dice)
		{
		static struct snd_rawmidi_ops capture_ops = {
		.open = midi_open,
		.close = midi_close,
		.trigger = midi_capture_trigger,
		};
		static struct snd_rawmidi_ops playback_ops = {
		.open = midi_open,
		.close = midi_close,
		.trigger = midi_playback_trigger,
		};
		__be32 reg;
		struct snd_rawmidi *rmidi;
		struct snd_rawmidi_str *str;

Admin message