Commit fc9bfbc6 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: Revert "media: atomisp: Add some ACPI detection info" 



This reverts commit 0d64e942.

As gmin_subdev_add() now takes the ACPI handle directly,
we can deprecate the code that were doing this inside each
I2C driver.

PS.: This also reverts commit c03496b3 ("media: atomisp: add a notice about possible leak resources")

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 387041cd

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+0 −11
Original line number Diff line number Diff line
@@ -1310,17 +1310,6 @@ static int gc0310_probe(struct i2c_client *client) 
	int ret;

	void *pdata;

	unsigned int i;

	acpi_handle handle;

	struct acpi_device *adev;



	handle = ACPI_HANDLE(&client->dev);

	if (!handle || acpi_bus_get_device(handle, &adev)) {

		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}

	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

+0 −11
Original line number Diff line number Diff line
@@ -1052,17 +1052,6 @@ static int gc2235_probe(struct i2c_client *client) 
	void *gcpdev;

	int ret;

	unsigned int i;

	acpi_handle handle;

	struct acpi_device *adev;



	handle = ACPI_HANDLE(&client->dev);

	if (!handle || acpi_bus_get_device(handle, &adev)) {

		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}

	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

drivers/staging/media/atomisp/i2c/atomisp-lm3554.c

+0 −11
Original line number Diff line number Diff line
@@ -851,17 +851,6 @@ static int lm3554_probe(struct i2c_client *client) 
	struct lm3554 *flash;

	unsigned int i;

	int ret;

	acpi_handle handle;

	struct acpi_device *adev;



	handle = ACPI_HANDLE(&client->dev);

	if (!handle || acpi_bus_get_device(handle, &adev)) {

		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}

	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	flash = kzalloc(sizeof(*flash), GFP_KERNEL);

	if (!flash)

drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c

+0 −11
Original line number Diff line number Diff line
@@ -1817,17 +1817,6 @@ static int mt9m114_probe(struct i2c_client *client) 
	int ret = 0;

	unsigned int i;

	void *pdata;

	acpi_handle handle;

	struct acpi_device *adev;



	handle = ACPI_HANDLE(&client->dev);

	if (!handle || acpi_bus_get_device(handle, &adev)) {

		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}

	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	/* Setup sensor configuration structure */

	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

drivers/staging/media/atomisp/i2c/atomisp-ov2680.c

+0 −11
Original line number Diff line number Diff line
@@ -1244,17 +1244,6 @@ static int ov2680_probe(struct i2c_client *client) 
	int ret;

	void *pdata;

	unsigned int i;

	acpi_handle handle;

	struct acpi_device *adev;



	handle = ACPI_HANDLE(&client->dev);

	if (!handle || acpi_bus_get_device(handle, &adev)) {

		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}

	dev_info(&client->dev, "%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE