Commit fc928b90 authored Dec 03, 2020 by Arnd Bergmann Committed by Viresh Kumar Dec 07, 2020

cpufreq: imx: fix NVMEM_IMX_OCOTP dependency



A driver should not 'select' drivers from another subsystem.
If NVMEM is disabled, this one results in a warning:

WARNING: unmet direct dependencies detected for NVMEM_IMX_OCOTP
  Depends on [n]: NVMEM [=n] && (ARCH_MXC [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
  Selected by [y]:
  - ARM_IMX6Q_CPUFREQ [=y] && CPU_FREQ [=y] && (ARM || ARM64 [=y]) && ARCH_MXC [=y] && REGULATOR_ANATOP [=y]

Change the 'select' to 'depends on' to prevent it from going wrong,
and allow compile-testing without that driver, since it is only
a runtime dependency.

Fixes: 2782ef34 ("cpufreq: imx: Select NVMEM_IMX_OCOTP")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent d1518399

drivers/cpufreq/Kconfig.arm

+1 −1

Original line number	Diff line number	Diff line
		@@ -94,7 +94,7 @@ config ARM_IMX6Q_CPUFREQ
		tristate "Freescale i.MX6 cpufreq support"
		depends on ARCH_MXC
		depends on REGULATOR_ANATOP
		select NVMEM_IMX_OCOTP
		depends on NVMEM_IMX_OCOTP \|\| COMPILE_TEST
		select PM_OPP
		help
		This adds cpufreq driver support for Freescale i.MX6 series SoCs.

Admin message