Commit fc90888d authored Oct 31, 2015 by Linus Torvalds

vfs: conditionally clear close-on-exec flag

We clear the close-on-exec flag when opening and closing files, and the
bit was almost always already clear before. Avoid dirtying the
cacheline if the clearning isn't necessary. That avoids unnecessary
cacheline dirtying and bouncing in multi-socket environments.

Eric Dumazet has a file descriptor benchmark that goes 4% faster from
this on his two-socket machine. It's probably partly superlinear
improvement due to getting slightly less spinlock contention on the
file_lock spinlock due to less work in the critical section.

Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f3f86e33

fs/file.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -236,6 +236,7 @@ static inline void __set_close_on_exec(int fd, struct fdtable *fdt)

	static inline void __clear_close_on_exec(int fd, struct fdtable *fdt)		static inline void __clear_close_on_exec(int fd, struct fdtable *fdt)
	{		{
			if (test_bit(fd, fdt->close_on_exec))
	__clear_bit(fd, fdt->close_on_exec);		__clear_bit(fd, fdt->close_on_exec);
	}		}

Admin message