Commit fc666936 authored Dec 10, 2019 by Dmitry Osipenko Committed by Stephen Boyd Dec 24, 2019

clk: tegra: Fix double-free in tegra_clk_init()



It's unlikely to happen in practice ever, but makes static checkers happy.

Fixes: 535f296d ("clk: tegra: Add suspend and resume support on Tegra210")
Reported-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lkml.kernel.org/r/20191210020512.6088-1-digetx@gmail.com


Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 67f96ff7

drivers/clk/tegra/clk.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -231,8 +231,10 @@ struct clk ** __init tegra_clk_init(void __iomem *regs, int num, int banks)
	periph_banks = banks;		periph_banks = banks;

	clks = kcalloc(num, sizeof(struct clk *), GFP_KERNEL);		clks = kcalloc(num, sizeof(struct clk *), GFP_KERNEL);
	if (!clks)		if (!clks) {
	kfree(periph_clk_enb_refcnt);		kfree(periph_clk_enb_refcnt);
			return NULL;
			}

	clk_num = num;		clk_num = num;

Admin message