perf evsel: perf_evsel__name(NULL) is valid, no need to check evsel (fc50e0ba) · Commits · 戴 / test

It'll return "unknown", no need to open code it. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Leo Yan <leo.yan@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/n/tip-4okvjmm18arjrcyfhuahgfxm@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/builtin-report.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -298,7 +298,7 @@ static int process_read_event(struct perf_tool *tool,
		struct report *rep = container_of(tool, struct report, tool);

		if (rep->show_threads) {
		const char *name = evsel ? perf_evsel__name(evsel) : "unknown";
		const char *name = perf_evsel__name(evsel);
		int err = perf_read_values_add_value(&rep->show_threads_values,
		event->read.pid, event->read.tid,
		evsel->idx,

tools/perf/util/session.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1246,7 +1246,7 @@ static void dump_read(struct perf_evsel evsel, union perf_event event)
		return;

		printf(": %d %d %s %" PRIu64 "\n", event->read.pid, event->read.tid,
		evsel ? perf_evsel__name(evsel) : "FAIL",
		perf_evsel__name(evsel),
		event->read.value);

		if (!evsel)

Admin message