Commit fc19cbb7 authored May 21, 2019 by Jeffrey Hugo Committed by Rob Clark Jun 18, 2019

drm/msm/mdp5: Fix mdp5_cfg_init error return



If mdp5_cfg_init fails because of an unknown major version, a null pointer
dereference occurs.  This is because the caller of init expects error
pointers, but init returns NULL on error.  Fix this by returning the
expected values on error.

Fixes: 2e362e17 (drm/msm/mdp5: introduce mdp5_cfg module)
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

parent 03b7af1e

drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -721,7 +721,7 @@ fail:
		if (cfg_handler)
		mdp5_cfg_destroy(cfg_handler);

		return NULL;
		return ERR_PTR(ret);
		}

		static struct mdp5_cfg_platform mdp5_get_config(struct platform_device dev)

Admin message