Commit fc01d8c6 authored Jan 01, 2019 by Paul Fulghum Committed by Greg Kroah-Hartman Jan 18, 2019

tty/n_hdlc: fix __might_sleep warning

Fix __might_sleep warning[1] in tty/n_hdlc.c read due to copy_to_user
call while current is TASK_INTERRUPTIBLE.  This is a false positive
since the code path does not depend on current state remaining
TASK_INTERRUPTIBLE.  The loop breaks out and sets TASK_RUNNING after
calling copy_to_user.

This patch supresses the warning by setting TASK_RUNNING before calling
copy_to_user.

[1] https://syzkaller.appspot.com/bug?id=17d5de7f1fcab794cb8c40032f893f52de899324



Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Reported-by: syzbot <syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: stable <stable@vger.kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 352c4cf4

drivers/tty/n_hdlc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -597,6 +597,7 @@ static ssize_t n_hdlc_tty_read(struct tty_struct tty, struct file file,
		/* too large for caller's buffer */
		ret = -EOVERFLOW;
		} else {
		__set_current_state(TASK_RUNNING);
		if (copy_to_user(buf, rbuf->buf, rbuf->count))
		ret = -EFAULT;
		else

Admin message