Commit fbf68b01 authored Feb 11, 2019 by Gustavo A. R. Silva Committed by David S. Miller Mar 10, 2019

ide: mark expected switch fall-through



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/ide/ide-floppy.c: In function ‘ide_floppy_get_capacity’:
drivers/ide/ide-floppy.c:424:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (!(drive->atapi_flags & IDE_AFLAG_CLIK_DRIVE))
       ^
drivers/ide/ide-floppy.c:431:3: note: here
   case CAPACITY_CURRENT:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 498b5894

drivers/ide/ide-floppy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -427,7 +427,7 @@ static int ide_floppy_get_capacity(ide_drive_t *drive)
		* (maintains previous driver behaviour)
		*/
		break;
		/* else: fall through */
		/* fall through */
		case CAPACITY_CURRENT:
		/* Normal Zip/LS-120 disks */
		if (memcmp(cap_desc, &floppy->cap_desc, 8))

Admin message