Commit fbeb1603 authored by Arthur Fabre's avatar Arthur Fabre Committed by Daniel Borkmann
Browse files

bpf: verifier: MOV64 don't mark dst reg unbounded 



When check_alu_op() handles a BPF_MOV64 between two registers,
it calls check_reg_arg(DST_OP) on the dst register, marking it
as unbounded. If the src and dst register are the same, this
marks the src as unbounded, which can lead to unexpected errors
for further checks that rely on bounds info. For example:

	BPF_MOV64_IMM(BPF_REG_2, 0),
	BPF_MOV64_REG(BPF_REG_2, BPF_REG_2),
	BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_2),
	BPF_MOV64_IMM(BPF_REG_0, 0),
	BPF_EXIT_INSN(),

Results in:

	"math between ctx pointer and register with unbounded
	min value is not allowed"

check_alu_op() now uses check_reg_arg(DST_OP_NO_MARK), and MOVs
that need to mark the dst register (MOVIMM, MOV32) do so.

Added a test case for MOV64 dst == src, and dst != src.

Signed-off-by: default avatarArthur Fabre <afabre@cloudflare.com>
Acked-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 194db0d9

kernel/bpf/verifier.c

+4 −2
Original line number Diff line number Diff line
@@ -3238,8 +3238,8 @@ static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn) 
			}

		}



		/* check dest operand */

		err = check_reg_arg(env, insn->dst_reg, DST_OP);

		/* check dest operand, mark as required later */

		err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);

		if (err)

			return err;
@@ -3265,6 +3265,8 @@ static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn) 
			/* case: R = imm

			 * remember the value we stored into this reg

			 */

			/* clear any state __mark_reg_known doesn't set */

			mark_reg_unknown(env, regs, insn->dst_reg);

			regs[insn->dst_reg].type = SCALAR_VALUE;

			if (BPF_CLASS(insn->code) == BPF_ALU64) {

				__mark_reg_known(regs + insn->dst_reg,

tools/testing/selftests/bpf/test_verifier.c

+26 −0
Original line number Diff line number Diff line
@@ -12332,6 +12332,32 @@ static struct bpf_test tests[] = { 
		.result = REJECT,

		.errstr = "variable ctx access var_off=(0x0; 0x4)",

	},

	{

		"mov64 src == dst",

		.insns = {

			BPF_MOV64_IMM(BPF_REG_2, 0),

			BPF_MOV64_REG(BPF_REG_2, BPF_REG_2),

			// Check bounds are OK

			BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_2),

			BPF_MOV64_IMM(BPF_REG_0, 0),

			BPF_EXIT_INSN(),

		},

		.prog_type = BPF_PROG_TYPE_SCHED_CLS,

		.result = ACCEPT,

	},

	{

		"mov64 src != dst",

		.insns = {

			BPF_MOV64_IMM(BPF_REG_3, 0),

			BPF_MOV64_REG(BPF_REG_2, BPF_REG_3),

			// Check bounds are OK

			BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_2),

			BPF_MOV64_IMM(BPF_REG_0, 0),

			BPF_EXIT_INSN(),

		},

		.prog_type = BPF_PROG_TYPE_SCHED_CLS,

		.result = ACCEPT,

	},

};



static int probe_filter_length(const struct bpf_insn *fp)

CRA Git | Maintained and supported by SUSTech CRA and CCSE