Commit fbd52eb2 authored by Ilpo Jrvinen's avatar Ilpo Jrvinen Committed by David S. Miller
Browse files

[TCP]: Split SACK FRTO flag clearing (fixes FRTO corner case bug) 



In case we run out of mem when fragmenting, the clearing of
FLAG_ONLY_ORIG_SACKED might get missed which then feeds FRTO
with false information. Move clearing outside skb processing
loop so that it will get executed even if the skb loop
terminates prematurely due to out-of-mem.

Besides, now the core of the loop truly deals with a single
skb only, which also enables creation a more self-contained
of tcp_sacktag_one later on.

In addition, small reorganization of if branches was made.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e49aa5d4

net/ipv4/tcp_input.c

+17 −18
Original line number Diff line number Diff line
@@ -1444,13 +1444,18 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_ 
						tp->retransmit_skb_hint = NULL;

					}

				} else {

					if (!(sacked & TCPCB_RETRANS)) {

						/* New sack for not retransmitted frame,

						 * which was in hole. It is reordering.

						 */

					if (!(sacked & TCPCB_RETRANS) &&

					    fack_count < prior_fackets)

						if (fack_count < prior_fackets)

							reord = min(fack_count, reord);



						/* SACK enhanced F-RTO (RFC4138; Appendix B) */

						if (!after(TCP_SKB_CB(skb)->end_seq, tp->frto_highmark))

							flag |= FLAG_ONLY_ORIG_SACKED;

					}



					if (sacked & TCPCB_LOST) {

						TCP_SKB_CB(skb)->sacked &= ~TCPCB_LOST;

						tp->lost_out -= tcp_skb_pcount(skb);
@@ -1458,18 +1463,6 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_ 
						/* clear lost hint */

						tp->retransmit_skb_hint = NULL;

					}

					/* SACK enhanced F-RTO detection.

					 * Set flag if and only if non-rexmitted

					 * segments below frto_highmark are

					 * SACKed (RFC4138; Appendix B).

					 * Clearing correct due to in-order walk

					 */

					if (after(end_seq, tp->frto_highmark)) {

						flag &= ~FLAG_ONLY_ORIG_SACKED;

					} else {

						if (!(sacked & TCPCB_RETRANS))

							flag |= FLAG_ONLY_ORIG_SACKED;

					}

				}



				TCP_SKB_CB(skb)->sacked |= TCPCB_SACKED_ACKED;
@@ -1503,6 +1496,12 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_ 
				tp->retransmit_skb_hint = NULL;

			}

		}



		/* SACK enhanced FRTO (RFC4138, Appendix B): Clearing correct

		 * due to in-order walk

		 */

		if (after(end_seq, tp->frto_highmark))

			flag &= ~FLAG_ONLY_ORIG_SACKED;

	}



	if (tp->retrans_out &&

CRA Git | Maintained and supported by SUSTech CRA and CCSE