Commit fbd03513 authored Sep 22, 2015 by Neil Armstrong Committed by David S. Miller Sep 22, 2015

net: dsa: Fix Marvell Egress Trailer check



The Marvell Egress rx trailer check must be fixed to
correctly detect bad bits in the third byte of the
Eggress trailer as described in the Table 28 of the
88E6060 datasheet.
The current code incorrectly omits to check the third
byte and checks the fourth byte twice.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7def0f95

net/dsa/tag_trailer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -78,7 +78,7 @@ static int trailer_rcv(struct sk_buff skb, struct net_device dev,

		trailer = skb_tail_pointer(skb) - 4;
		if (trailer[0] != 0x80 \|\| (trailer[1] & 0xf8) != 0x00 \|\|
		(trailer[3] & 0xef) != 0x00 \|\| trailer[3] != 0x00)
		(trailer[2] & 0xef) != 0x00 \|\| trailer[3] != 0x00)
		goto out_drop;

		source_port = trailer[1] & 7;

Admin message