Commit fbbbbd2f authored May 10, 2019 by Colin Ian King Committed by Theodore Ts'o May 10, 2019

ext4: unsigned int compared against zero

There are two cases where u32 variables n and err are being checked
for less than zero error values, the checks is always false because
the variables are not signed. Fix this by making the variables ints.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 345c0dbf ("ext4: protect journal inode's blocks using block_validity")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 08fc98a4

fs/ext4/block_validity.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino)
		struct inode *inode;
		struct ext4_sb_info *sbi = EXT4_SB(sb);
		struct ext4_map_blocks map;
		u32 i = 0, err = 0, num, n;
		u32 i = 0, num;
		int err = 0, n;

		if ((ino < EXT4_ROOT_INO) \|\|
		(ino > le32_to_cpu(sbi->s_es->s_inodes_count)))

Admin message