Commit fba63097 authored Oct 13, 2011 by Mike Miller Committed by James Bottomley Oct 20, 2011

[SCSI] hpsa: change confusing message to be more clear



The following warning message may be confusing to some users:

dev_warn(&pdev->dev, "Controller claims that "
		"'Bit 2 doorbell reset' is "
		"supported, but not 'bit 5 doorbell reset'.  "
		"Firmware update is recommended.\n");

Most users don't know or care what bit we may be hitting. Also change
"recommended" to "required."

Signed-off-by: Mike Miller <mike.miller@hp.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 2d63673b

drivers/scsi/hpsa.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -3438,10 +3438,8 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
		} else {
		use_doorbell = misc_fw_support & MISC_FW_DOORBELL_RESET;
		if (use_doorbell) {
		dev_warn(&pdev->dev, "Controller claims that "
		"'Bit 2 doorbell reset' is "
		"supported, but not 'bit 5 doorbell reset'. "
		"Firmware update is recommended.\n");
		dev_warn(&pdev->dev, "Soft reset not supported. "
		"Firmware update is required.\n");
		rc = -ENOTSUPP; /* try soft reset */
		goto unmap_cfgtable;
		}

Admin message