pkt_sched: add cond_resched() to class and qdisc dump (fba373d2) · Commits · 戴 / test

We have seen delays of more than 50ms in class or qdisc dumps, in case device is under high TX stress, even with the prior 4KB per skb limit. Add cond_resched() to give a chance to higher prio tasks to get cpu. Signed-off-by; Eric Dumazet <edumazet@google.com> Signed-off-by:

Eric Dumazet <edumazet@google.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sched/sch_api.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1303,6 +1303,7 @@ static int tc_fill_qdisc(struct sk_buff skb, struct Qdisc q, u32 clid,
		struct gnet_dump d;
		struct qdisc_size_table *stab;

		cond_resched();
		nlh = nlmsg_put(skb, portid, seq, event, sizeof(*tcm), flags);
		if (!nlh)
		goto out_nlmsg_trim;
		@@ -1615,6 +1616,7 @@ static int tc_fill_tclass(struct sk_buff skb, struct Qdisc q,
		struct gnet_dump d;
		const struct Qdisc_class_ops *cl_ops = q->ops->cl_ops;

		cond_resched();
		nlh = nlmsg_put(skb, portid, seq, event, sizeof(*tcm), flags);
		if (!nlh)
		goto out_nlmsg_trim;

Admin message