Commit fb9024b0 authored May 04, 2020 by Ewan D. Milne Committed by Martin K. Petersen May 11, 2020

scsi: qla2xxx: Do not log message when reading port speed via sysfs

Calling ql_log() inside qla2x00_port_speed_show() is causing messages to be
output to the console for no particularly good reason.  The sysfs read
routine should just return the information to userspace.  The only reason
to log a message is when the port speed actually changes, and this already
occurs elsewhere.

Link: https://lore.kernel.org/r/20200504175416.15417-1-emilne@redhat.com


Fixes: 4910b524 ("scsi: qla2xxx: Add support for setting port speed")
Cc: <stable@vger.kernel.org> # v5.1+
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent b3652215

drivers/scsi/qla2xxx/qla_attr.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1850,9 +1850,6 @@ qla2x00_port_speed_show(struct device dev, struct device_attribute attr,
		return -EINVAL;
		}

		ql_log(ql_log_info, vha, 0x70d6,
		"port speed:%d\n", ha->link_data_rate);

		return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]);
		}

Admin message