Commit fb79c066 authored Jun 06, 2015 by Nicholas Mc Guire Committed by David S. Miller Jun 07, 2015

cosa: use msecs_to_jiffies for conversions



API compliance scanning with coccinelle flagged:
./drivers/net/wan/cosa.c:520:2-18: WARNING:
	timeout (30) seems HZ dependent

Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a device probe.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7cf7fa52

drivers/net/wan/cosa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -517,7 +517,7 @@ static int cosa_probe(int base, int irq, int dma)
		*/
		set_current_state(TASK_INTERRUPTIBLE);
		cosa_putstatus(cosa, SR_TX_INT_ENA);
		schedule_timeout(30);
		schedule_timeout(msecs_to_jiffies(300));
		irq = probe_irq_off(irqs);
		/* Disable all IRQs from the card */
		cosa_putstatus(cosa, 0);

Admin message