Commit fb53a1ab authored Jan 23, 2014 by Aravind Gopalakrishnan Committed by Ingo Molnar Jan 25, 2014

x86/quirks: Add workaround for AMD F16h Erratum792



The workaround for this Erratum is included in AGESA. But BIOSes
spun only after Jan2014 will have the fix (atleast server
versions of the chip). The erratum affects both embedded and
server platforms and since we cannot say with certainity that
ALL BIOSes on systems out in the field will have the fix, we
should probably insulate ourselves in case BIOS does not do the
right thing or someone is using old BIOSes.

Refer to Revision Guide for AMD F16h models 00h-0fh, document 51810
Rev. 3.04, November2013 for details on the Erratum.

Tested the patch on Fam16h server platform and it works fine.

Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Cc: <hmh@hmh.eng.br>
Cc: <Kim.Naru@amd.com>
Cc: <Suravee.Suthikulpanit@amd.com>
Cc: <bp@suse.de>
Cc: <sherry.hurwitz@amd.com>
Link: http://lkml.kernel.org/r/1390515212-1824-1-git-send-email-Aravind.Gopalakrishnan@amd.com


[ Minor edits. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent b8989db9

arch/x86/kernel/quirks.c

+37 −0

Original line number	Diff line number	Diff line
		@@ -571,3 +571,40 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F5,
		quirk_amd_nb_node);

		#endif

		#ifdef CONFIG_PCI
		/*
		* Processor does not ensure DRAM scrub read/write sequence
		* is atomic wrt accesses to CC6 save state area. Therefore
		* if a concurrent scrub read/write access is to same address
		* the entry may appear as if it is not written. This quirk
		* applies to Fam16h models 00h-0Fh
		*
		* See "Revision Guide" for AMD F16h models 00h-0fh,
		* document 51810 rev. 3.04, Nov 2013
		*/
		static void amd_disable_seq_and_redirect_scrub(struct pci_dev *dev)
		{
		u32 val;

		/*
		* Suggested workaround:
		* set D18F3x58[4:0] = 00h and set D18F3x5C[0] = 0b
		*/
		pci_read_config_dword(dev, 0x58, &val);
		if (val & 0x1F) {
		val &= ~(0x1F);
		pci_write_config_dword(dev, 0x58, val);
		}

		pci_read_config_dword(dev, 0x5C, &val);
		if (val & BIT(0)) {
		val &= ~BIT(0);
		pci_write_config_dword(dev, 0x5c, val);
		}
		}

		DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_NB_F3,
		amd_disable_seq_and_redirect_scrub);

		#endif

Admin message