Commit fb2cf2c6 authored Apr 25, 2012 by he, bo Committed by Ingo Molnar Apr 26, 2012

sched: Fix OOPS when build_sched_domains() percpu allocation fails



Under extreme memory used up situations, percpu allocation
might fail. We hit it when system goes to suspend-to-ram,
causing a kworker panic:

 EIP: [<c124411a>] build_sched_domains+0x23a/0xad0
 Kernel panic - not syncing: Fatal exception
 Pid: 3026, comm: kworker/u:3
 3.0.8-137473-gf42fbef #1

 Call Trace:
  [<c18cc4f2>] panic+0x66/0x16c
  [...]
  [<c1244c37>] partition_sched_domains+0x287/0x4b0
  [<c12a77be>] cpuset_update_active_cpus+0x1fe/0x210
  [<c123712d>] cpuset_cpu_inactive+0x1d/0x30
  [...]

With this fix applied build_sched_domains() will return -ENOMEM and
the suspend attempt fails.

Signed-off-by: he, bo <bo.he@intel.com>
Reviewed-by: Zhang, Yanmin <yanmin.zhang@intel.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@kernel.org>
Link: http://lkml.kernel.org/r/1335355161.5892.17.camel@hebo


[ So, we fail to deallocate a CPU because we cannot allocate RAM :-/
  I don't like that kind of sad behavior but nevertheless it should
  not crash under high memory load. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent eb95308e

kernel/sched/core.c

+16 −6

Original line number	Diff line number	Diff line
		@@ -6405,16 +6405,26 @@ static void __sdt_free(const struct cpumask *cpu_map)
		struct sd_data *sdd = &tl->data;

		for_each_cpu(j, cpu_map) {
		struct sched_domain sd = per_cpu_ptr(sdd->sd, j);
		struct sched_domain *sd;

		if (sdd->sd) {
		sd = *per_cpu_ptr(sdd->sd, j);
		if (sd && (sd->flags & SD_OVERLAP))
		free_sched_groups(sd->groups, 0);
		kfree(*per_cpu_ptr(sdd->sd, j));
		}

		if (sdd->sg)
		kfree(*per_cpu_ptr(sdd->sg, j));
		if (sdd->sgp)
		kfree(*per_cpu_ptr(sdd->sgp, j));
		}
		free_percpu(sdd->sd);
		sdd->sd = NULL;
		free_percpu(sdd->sg);
		sdd->sg = NULL;
		free_percpu(sdd->sgp);
		sdd->sgp = NULL;
		}
		}

Admin message