Commit fb223c32 authored Nov 02, 2011 by Jonathan Corbet Committed by Herbert Xu Nov 02, 2011

crypto: user - Fix rwsem leak in crypto_user

The list_empty case in crypto_alg_match() will return without calling
up_read() on crypto_alg_sem. We could do the "goto out" routine, but the
function will clearly do the right thing with that test simply removed.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 5db017aa

crypto/crypto_user.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -44,9 +44,6 @@ static struct crypto_alg crypto_alg_match(struct crypto_user_alg p, int exact)

		down_read(&crypto_alg_sem);

		if (list_empty(&crypto_alg_list))
		return NULL;

		list_for_each_entry(q, &crypto_alg_list, cra_list) {
		int match = 0;

Admin message