ice: print opcode when printing controlq errors (fb0254b2) · Commits · 戴 / test

To help aid in debugging, display the command opcode in debug messages that print an error code. This makes it easier to see what command failed if only ICE_DBG_AQ_MSG is enabled. Signed-off-by:

Jacob Keller <jacob.e.keller@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/ice/ice_controlq.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1017,7 +1017,8 @@ ice_sq_send_cmd(struct ice_hw hw, struct ice_ctl_q_info cq,
		retval = le16_to_cpu(desc->retval);
		if (retval) {
		ice_debug(hw, ICE_DBG_AQ_MSG,
		"Control Send Queue command completed with error 0x%x\n",
		"Control Send Queue command 0x%04X completed with error 0x%X\n",
		le16_to_cpu(desc->opcode),
		retval);

		/* strip off FW internal code */
		@@ -1121,7 +1122,8 @@ ice_clean_rq_elem(struct ice_hw hw, struct ice_ctl_q_info cq,
		if (flags & ICE_AQ_FLAG_ERR) {
		ret_code = ICE_ERR_AQ_ERROR;
		ice_debug(hw, ICE_DBG_AQ_MSG,
		"Control Receive Queue Event received with error 0x%x\n",
		"Control Receive Queue Event 0x%04X received with error 0x%X\n",
		le16_to_cpu(desc->opcode),
		cq->rq_last_status);
		}
		memcpy(&e->desc, desc, sizeof(e->desc));

Admin message