Commit fafbc202 authored Aug 07, 2012 by Jesper Juhl Committed by Greg Kroah-Hartman Aug 13, 2012

staging: speakup: i18n.c: Fix leak in msg_set()



If we end up returning -EINVAL from the function we will leak the
memory allocated to 'newstr' which has been allocated but not yet
assigned to anything.
Fix the leak by properly freeing the memory again before we return.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 935d59ff

drivers/staging/speakup/i18n.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -555,6 +555,7 @@ ssize_t msg_set(enum msg_index_t index, char *text, size_t length)
		&& index <= MSG_FORMATTED_END)
		&& !fmt_validate(speakup_default_msgs[index],
		newstr)) {
		kfree(newstr);
		return -EINVAL;
		}
		spk_lock(flags);

Admin message