Commit faef080f authored Mar 12, 2019 by Viresh Kumar Committed by Rafael J. Wysocki Mar 12, 2019

PM / OPP: Update performance state when freq == old_freq



At boot up, CPUFreq core performs a sanity check to see if the system is
running at a frequency defined in the frequency table of the CPU. If so,
we try to find a valid frequency (lowest frequency greater than the
currently programmed frequency) from the table and set it. When the call
reaches dev_pm_opp_set_rate(), it calls _find_freq_ceil(opp_table,
&old_freq) to find the previously configured OPP and this call also
updates the old_freq. This eventually sets the old_freq == freq (new
target requested by cpufreq core) and we skip updating the performance
state in this case.

Fix this by also updating the performance state when the old_freq ==
freq.

Fixes: ca1b5d77 ("OPP: Configure all required OPPs")
Cc: v5.0 <stable@vger.kernel.org> # v5.0
Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Tested-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 55286a29

drivers/opp/core.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -760,7 +760,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
	old_freq, freq);		old_freq, freq);

	/* Scaling up? Configure required OPPs before frequency */		/* Scaling up? Configure required OPPs before frequency */
	if (freq > old_freq) {		if (freq >= old_freq) {
	ret = _set_required_opps(dev, opp_table, opp);		ret = _set_required_opps(dev, opp_table, opp);
	if (ret)		if (ret)
	goto put_opp;		goto put_opp;

Admin message