Commit fae07dc3 authored Dec 11, 2006 by Tejun Heo Committed by Jeff Garzik Dec 16, 2006

[PATCH] ata_piix: use piix_host_stop() in ich_pata_ops



piix_init_one() allocates host private data which should be freed by
piix_host_stop().  ich_pata_ops wasn't converted to piix_host_stop()
while merging, leaking 4 bytes on driver detach.  Fix it.

This was spotted using Kmemleak by Catalin Marinas.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent f98b6573

drivers/ata/ata_piix.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -342,7 +342,7 @@ static const struct ata_port_operations ich_pata_ops = {

		.port_start = ata_port_start,
		.port_stop = ata_port_stop,
		.host_stop = ata_host_stop,
		.host_stop = piix_host_stop,
		};

		static const struct ata_port_operations piix_sata_ops = {

Admin message