Commit faddf598 authored by Matt Fleming's avatar Matt Fleming Committed by David S. Miller
Browse files

sparc: Use set_current_blocked() 



As described in e6fa16ab ("signal: sigprocmask() should do
retarget_shared_pending()") the modification of current->blocked is
incorrect as we need to check whether the signal we're about to block
is pending in the shared queue.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: default avatarMatt Fleming <matt.fleming@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f22ed71c

arch/sparc/kernel/signal32.c

+6 −13
Original line number Diff line number Diff line
@@ -273,10 +273,7 @@ void do_sigreturn32(struct pt_regs *regs) 
		case 1: set.sig[0] = seta[0] + (((long)seta[1]) << 32);

	}

	sigdelsetmask(&set, ~_BLOCKABLE);

	spin_lock_irq(&current->sighand->siglock);

	current->blocked = set;

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

	set_current_blocked(&set);

	return;



segv:
@@ -377,10 +374,7 @@ asmlinkage void do_rt_sigreturn32(struct pt_regs *regs) 
		case 1: set.sig[0] = seta.sig[0] + (((long)seta.sig[1]) << 32);

	}

	sigdelsetmask(&set, ~_BLOCKABLE);

	spin_lock_irq(&current->sighand->siglock);

	current->blocked = set;

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

	set_current_blocked(&set);

	return;

segv:

	force_sig(SIGSEGV, current);
@@ -782,6 +776,7 @@ static inline int handle_signal32(unsigned long signr, struct k_sigaction *ka, 
				  siginfo_t *info,

				  sigset_t *oldset, struct pt_regs *regs)

{

	sigset_t blocked;

	int err;



	if (ka->sa.sa_flags & SA_SIGINFO)
@@ -792,12 +787,10 @@ static inline int handle_signal32(unsigned long signr, struct k_sigaction *ka, 
	if (err)

		return err;



	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	sigorsets(&blocked, &current->blocked, &ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NOMASK))

		sigaddset(&current->blocked,signr);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

		sigaddset(&blocked, signr);

	set_current_blocked(&blocked);



	tracehook_signal_handler(signr, info, ka, regs, 0);

arch/sparc/kernel/signal_32.c

+12 −18
Original line number Diff line number Diff line
@@ -62,12 +62,13 @@ struct rt_signal_frame { 


static int _sigpause_common(old_sigset_t set)

{

	set &= _BLOCKABLE;

	spin_lock_irq(&current->sighand->siglock);

	sigset_t blocked;



	current->saved_sigmask = current->blocked;

	siginitset(&current->blocked, set);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);



	set &= _BLOCKABLE;

	siginitset(&blocked, set);

	set_current_blocked(&blocked);



	current->state = TASK_INTERRUPTIBLE;

	schedule();
@@ -139,10 +140,7 @@ asmlinkage void do_sigreturn(struct pt_regs *regs) 
		goto segv_and_exit;



	sigdelsetmask(&set, ~_BLOCKABLE);

	spin_lock_irq(&current->sighand->siglock);

	current->blocked = set;

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

	set_current_blocked(&set);

	return;



segv_and_exit:
@@ -209,10 +207,7 @@ asmlinkage void do_rt_sigreturn(struct pt_regs *regs) 
	}



	sigdelsetmask(&set, ~_BLOCKABLE);

	spin_lock_irq(&current->sighand->siglock);

	current->blocked = set;

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

	set_current_blocked(&set);

	return;

segv:

	force_sig(SIGSEGV, current);
@@ -470,6 +465,7 @@ static inline int 
handle_signal(unsigned long signr, struct k_sigaction *ka,

	      siginfo_t *info, sigset_t *oldset, struct pt_regs *regs)

{

	sigset_t blocked;

	int err;



	if (ka->sa.sa_flags & SA_SIGINFO)
@@ -480,12 +476,10 @@ handle_signal(unsigned long signr, struct k_sigaction *ka, 
	if (err)

		return err;



	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	sigorsets(&blocked, &current->blocked, &ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NOMASK))

		sigaddset(&current->blocked, signr);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

		sigaddset(&blocked, signr);

	set_current_blocked(&blocked);



	tracehook_signal_handler(signr, info, ka, regs, 0);

arch/sparc/kernel/signal_64.c

+12 −18
Original line number Diff line number Diff line
@@ -70,10 +70,7 @@ asmlinkage void sparc64_set_context(struct pt_regs *regs) 
				goto do_sigsegv;

		}

		sigdelsetmask(&set, ~_BLOCKABLE);

		spin_lock_irq(&current->sighand->siglock);

		current->blocked = set;

		recalc_sigpending();

		spin_unlock_irq(&current->sighand->siglock);

		set_current_blocked(&set);

	}

	if (test_thread_flag(TIF_32BIT)) {

		pc &= 0xffffffff;
@@ -242,12 +239,13 @@ struct rt_signal_frame { 


static long _sigpause_common(old_sigset_t set)

{

	set &= _BLOCKABLE;

	spin_lock_irq(&current->sighand->siglock);

	sigset_t blocked;



	current->saved_sigmask = current->blocked;

	siginitset(&current->blocked, set);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);



	set &= _BLOCKABLE;

	siginitset(&blocked, set);

	set_current_blocked(&blocked);



	current->state = TASK_INTERRUPTIBLE;

	schedule();
@@ -327,10 +325,7 @@ void do_rt_sigreturn(struct pt_regs *regs) 
	pt_regs_clear_syscall(regs);



	sigdelsetmask(&set, ~_BLOCKABLE);

	spin_lock_irq(&current->sighand->siglock);

	current->blocked = set;

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

	set_current_blocked(&set);

	return;

segv:

	force_sig(SIGSEGV, current);
@@ -484,18 +479,17 @@ static inline int handle_signal(unsigned long signr, struct k_sigaction *ka, 
				siginfo_t *info,

				sigset_t *oldset, struct pt_regs *regs)

{

	sigset_t blocked;

	int err;



	err = setup_rt_frame(ka, regs, signr, oldset,

			     (ka->sa.sa_flags & SA_SIGINFO) ? info : NULL);

	if (err)

		return err;

	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	sigorsets(&blocked, &current->blocked, &ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NOMASK))

		sigaddset(&current->blocked,signr);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

		sigaddset(&blocked, signr);

	set_current_blocked(&blocked);



	tracehook_signal_handler(signr, info, ka, regs, 0);

CRA Git | Maintained and supported by SUSTech CRA and CCSE