Commit fad99fac authored Oct 20, 2010 by Jason Wessel

x86,kgdb: fix debugger hw breakpoint test regression in 2.6.35



HW breakpoints events stopped working correctly with kgdb as a result
of commit: 018cbffe (Merge commit
'v2.6.33' into perf/core), later commit:
ba773f7c (x86,kgdb: Fix hw breakpoint
regression) allowed breakpoints to propagate to the debugger core but
did not completely address the original regression in functionality
found in 2.6.35.

When the DR_STEP flag is set in dr6 along with any of the DR_TRAP
bits, the kgdb exception handler will enter once from the
hw_breakpoint API call back and again from the die notifier for
do_debug(), which causes the debugger to stop twice and also for the
kgdb regression tests to fail running under kvm with:

echo V2I1 > /sys/module/kgdbts/parameters/kgdbts

To address the problem, the kgdb overflow handler needs to implement
the same logic as the ptrace overflow handler call back with respect
to updating the virtual copy of dr6.  This will allow the kgdb
do_debug() die notifier to properly handle the exception and the
attached debugger, or kgdb test suite, will only receive a single
notification.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: x86@kernel.org

parent f5d9d249

arch/x86/kernel/kgdb.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -621,7 +621,12 @@ int kgdb_arch_init(void)
		static void kgdb_hw_overflow_handler(struct perf_event *event, int nmi,
		struct perf_sample_data data, struct pt_regs regs)
		{
		kgdb_ll_trap(DIE_DEBUG, "debug", regs, 0, 0, SIGTRAP);
		struct task_struct *tsk = current;
		int i;

		for (i = 0; i < 4; i++)
		if (breakinfo[i].enabled)
		tsk->thread.debugreg6 \|= (DR_TRAP0 << i);
		}

		void kgdb_arch_late(void)

Admin message