Commit facb4edc authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

phonet: some signedness bugs 

Dan Rosenberg pointed out that there were some signed comparison bugs
in the phonet protocol.

http://marc.info/?l=full-disclosure&m=129424528425330&w=2



The problem is that we check for array overflows but "protocol" is
signed and we don't check for array underflows.  If you have already
have CAP_SYS_ADMIN then you could use the bugs to get root, or someone
could cause an oops by mistake.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarRémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c599bd6b

include/net/phonet/phonet.h

+2 −2
Original line number Diff line number Diff line
@@ -107,8 +107,8 @@ struct phonet_protocol { 
	int			sock_type;

};



int phonet_proto_register(int protocol, struct phonet_protocol *pp);

void phonet_proto_unregister(int protocol, struct phonet_protocol *pp);

int phonet_proto_register(unsigned int protocol, struct phonet_protocol *pp);

void phonet_proto_unregister(unsigned int protocol, struct phonet_protocol *pp);



int phonet_sysctl_init(void);

void phonet_sysctl_exit(void);

net/phonet/af_phonet.c

+3 −3
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ 
/* Transport protocol registration */

static struct phonet_protocol *proto_tab[PHONET_NPROTO] __read_mostly;



static struct phonet_protocol *phonet_proto_get(int protocol)

static struct phonet_protocol *phonet_proto_get(unsigned int protocol)

{

	struct phonet_protocol *pp;
@@ -458,7 +458,7 @@ static struct packet_type phonet_packet_type __read_mostly = { 


static DEFINE_MUTEX(proto_tab_lock);



int __init_or_module phonet_proto_register(int protocol,

int __init_or_module phonet_proto_register(unsigned int protocol,

						struct phonet_protocol *pp)

{

	int err = 0;
@@ -481,7 +481,7 @@ int __init_or_module phonet_proto_register(int protocol, 
}

EXPORT_SYMBOL(phonet_proto_register);



void phonet_proto_unregister(int protocol, struct phonet_protocol *pp)

void phonet_proto_unregister(unsigned int protocol, struct phonet_protocol *pp)

{

	mutex_lock(&proto_tab_lock);

	BUG_ON(proto_tab[protocol] != pp);

CRA Git | Maintained and supported by SUSTech CRA and CCSE