Commit fab686eb authored by Jann Horn's avatar Jann Horn Committed by Kees Cook
Browse files

seccomp: Remove bogus __user annotations 



Buffers that are passed to read_actions_logged() and write_actions_logged()
are in kernel memory; the sysctl core takes care of copying from/to
userspace.

Fixes: 32927393 ("sysctl: pass kernel pointers to ->proc_handler")
Reviewed-by: default avatarTyler Hicks <code@tyhicks.com>
Signed-off-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20201120170545.1419332-1-jannh@google.com
parent 0d8315dd

kernel/seccomp.c

+2 −2
Original line number Diff line number Diff line
@@ -2202,7 +2202,7 @@ static bool seccomp_actions_logged_from_names(u32 *actions_logged, char *names) 
	return true;

}



static int read_actions_logged(struct ctl_table *ro_table, void __user *buffer,

static int read_actions_logged(struct ctl_table *ro_table, void *buffer,

			       size_t *lenp, loff_t *ppos)

{

	char names[sizeof(seccomp_actions_avail)];
@@ -2220,7 +2220,7 @@ static int read_actions_logged(struct ctl_table *ro_table, void __user *buffer, 
	return proc_dostring(&table, 0, buffer, lenp, ppos);

}



static int write_actions_logged(struct ctl_table *ro_table, void __user *buffer,

static int write_actions_logged(struct ctl_table *ro_table, void *buffer,

				size_t *lenp, loff_t *ppos, u32 *actions_logged)

{

	char names[sizeof(seccomp_actions_avail)];

CRA Git | Maintained and supported by SUSTech CRA and CCSE