Commit fab683eb authored Jan 20, 2016 by Arnd Bergmann Committed by Nicholas Bellinger Jan 20, 2016

scsi: qla2xxxx: avoid type mismatch in comparison



A recent bug fix added code that does

        bool logged_out = (status & 0xFFFF);
        if (logged_out == CTIO_PORT_LOGGED_OUT)
		...

This looks wrong because we are comparing a boolean with an
integer constant, ang gcc warns about it accordingly:

drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion':
drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare]
        (logged_out == CTIO_PORT_LOGGED_OUT) ?

The correct fix is presumably to make that variable an 'int'.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 71cdc079 ("qla2xxx: Delete session if initiator is gone from FW")
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 20c08b36

drivers/scsi/qla2xxx/qla_target.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3580,7 +3580,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
		case CTIO_PORT_LOGGED_OUT:
		case CTIO_PORT_UNAVAILABLE:
		{
		bool logged_out = (status & 0xFFFF);
		int logged_out = (status & 0xFFFF);
		ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
		"qla_target(%d): CTIO with %s status %x "
		"received (state %x, se_cmd %p)\n", vha->vp_idx,

Admin message