Commit fa89d31c authored by Dave Martin's avatar Dave Martin Committed by Marc Zyngier
Browse files

KVM: arm64: Repurpose vcpu_arch.debug_flags for general-purpose flags 



In struct vcpu_arch, the debug_flags field is used to store
debug-related flags about the vcpu state.

Since we are about to add some more flags related to FPSIMD and
SVE, it makes sense to add them to the existing flags field rather
than adding new fields.  Since there is only one debug_flags flag
defined so far, there is plenty of free space for expansion.

In preparation for adding more flags, this patch renames the
debug_flags field to simply "flags", and updates comments
appropriately.

The flag definitions are also moved to <asm/kvm_host.h>, since
their presence in <asm/kvm_asm.h> was for purely historical
reasons:  these definitions are not used from asm any more, and not
very likely to be as more Hyp asm is migrated to C.

KVM_ARM64_DEBUG_DIRTY_SHIFT has not been used since commit
1ea66d27 ("arm64: KVM: Move away from the assembly version of
the world switch"), so this patch gets rid of that too.

No functional change.

Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
Reviewed-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Acked-by: default avatarChristoffer Dall <christoffer.dall@arm.com>
[maz: fixed minor conflict]
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 0cff8e77

arch/arm64/include/asm/kvm_asm.h

+0 −3
Original line number Original line Diff line number Diff line
@@ -30,9 +30,6 @@ 
/* The hyp-stub will return this for any kvm_call_hyp() call */

/* The hyp-stub will return this for any kvm_call_hyp() call */

#define ARM_EXCEPTION_HYP_GONE	  HVC_STUB_ERR

#define ARM_EXCEPTION_HYP_GONE	  HVC_STUB_ERR





#define KVM_ARM64_DEBUG_DIRTY_SHIFT	0

#define KVM_ARM64_DEBUG_DIRTY		(1 << KVM_ARM64_DEBUG_DIRTY_SHIFT)



#ifndef __ASSEMBLY__

#ifndef __ASSEMBLY__





#include <linux/mm.h>

#include <linux/mm.h>

arch/arm64/include/asm/kvm_host.h

+5 −2
Original line number Original line Diff line number Diff line
@@ -216,8 +216,8 @@ struct kvm_vcpu_arch { 
	/* Exception Information */

	/* Exception Information */

	struct kvm_vcpu_fault_info fault;

	struct kvm_vcpu_fault_info fault;





	/* Guest debug state */

	/* Miscellaneous vcpu state flags */

	u64 debug_flags;

	u64 flags;





	/*

	/*

	 * We maintain more than a single set of debug registers to support

	 * We maintain more than a single set of debug registers to support
@@ -293,6 +293,9 @@ struct kvm_vcpu_arch { 
	bool sysregs_loaded_on_cpu;

	bool sysregs_loaded_on_cpu;

};

};





/* vcpu_arch flags field values: */

#define KVM_ARM64_DEBUG_DIRTY		(1 << 0)



#define vcpu_gp_regs(v)		(&(v)->arch.ctxt.gp_regs)

#define vcpu_gp_regs(v)		(&(v)->arch.ctxt.gp_regs)





/*

/*

arch/arm64/kvm/debug.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -103,7 +103,7 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) 
 *

 *

 * Additionally, KVM only traps guest accesses to the debug registers if

 * Additionally, KVM only traps guest accesses to the debug registers if

 * the guest is not actively using them (see the KVM_ARM64_DEBUG_DIRTY

 * the guest is not actively using them (see the KVM_ARM64_DEBUG_DIRTY

 * flag on vcpu->arch.debug_flags).  Since the guest must not interfere

 * flag on vcpu->arch.flags).  Since the guest must not interfere

 * with the hardware state when debugging the guest, we must ensure that

 * with the hardware state when debugging the guest, we must ensure that

 * trapping is enabled whenever we are debugging the guest using the

 * trapping is enabled whenever we are debugging the guest using the

 * debug registers.

 * debug registers.
@@ -111,7 +111,7 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) 




void kvm_arm_setup_debug(struct kvm_vcpu *vcpu)

void kvm_arm_setup_debug(struct kvm_vcpu *vcpu)

{

{

	bool trap_debug = !(vcpu->arch.debug_flags & KVM_ARM64_DEBUG_DIRTY);

	bool trap_debug = !(vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY);

	unsigned long mdscr;

	unsigned long mdscr;





	trace_kvm_arm_setup_debug(vcpu, vcpu->guest_debug);

	trace_kvm_arm_setup_debug(vcpu, vcpu->guest_debug);
@@ -184,7 +184,7 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) 
			vcpu_write_sys_reg(vcpu, mdscr, MDSCR_EL1);

			vcpu_write_sys_reg(vcpu, mdscr, MDSCR_EL1);





			vcpu->arch.debug_ptr = &vcpu->arch.external_debug_state;

			vcpu->arch.debug_ptr = &vcpu->arch.external_debug_state;

			vcpu->arch.debug_flags |= KVM_ARM64_DEBUG_DIRTY;

			vcpu->arch.flags |= KVM_ARM64_DEBUG_DIRTY;

			trap_debug = true;

			trap_debug = true;





			trace_kvm_arm_set_regset("BKPTS", get_num_brps(),

			trace_kvm_arm_set_regset("BKPTS", get_num_brps(),
@@ -206,7 +206,7 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) 




	/* If KDE or MDE are set, perform a full save/restore cycle. */

	/* If KDE or MDE are set, perform a full save/restore cycle. */

	if (vcpu_read_sys_reg(vcpu, MDSCR_EL1) & (DBG_MDSCR_KDE | DBG_MDSCR_MDE))

	if (vcpu_read_sys_reg(vcpu, MDSCR_EL1) & (DBG_MDSCR_KDE | DBG_MDSCR_MDE))

		vcpu->arch.debug_flags |= KVM_ARM64_DEBUG_DIRTY;

		vcpu->arch.flags |= KVM_ARM64_DEBUG_DIRTY;





	trace_kvm_arm_set_dreg32("MDCR_EL2", vcpu->arch.mdcr_el2);

	trace_kvm_arm_set_dreg32("MDCR_EL2", vcpu->arch.mdcr_el2);

	trace_kvm_arm_set_dreg32("MDSCR_EL1", vcpu_read_sys_reg(vcpu, MDSCR_EL1));

	trace_kvm_arm_set_dreg32("MDSCR_EL1", vcpu_read_sys_reg(vcpu, MDSCR_EL1));

arch/arm64/kvm/hyp/debug-sr.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -163,7 +163,7 @@ void __hyp_text __debug_switch_to_guest(struct kvm_vcpu *vcpu) 
	if (!has_vhe())

	if (!has_vhe())

		__debug_save_spe_nvhe(&vcpu->arch.host_debug_state.pmscr_el1);

		__debug_save_spe_nvhe(&vcpu->arch.host_debug_state.pmscr_el1);





	if (!(vcpu->arch.debug_flags & KVM_ARM64_DEBUG_DIRTY))

	if (!(vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY))

		return;

		return;





	host_ctxt = kern_hyp_va(vcpu->arch.host_cpu_context);

	host_ctxt = kern_hyp_va(vcpu->arch.host_cpu_context);
@@ -185,7 +185,7 @@ void __hyp_text __debug_switch_to_host(struct kvm_vcpu *vcpu) 
	if (!has_vhe())

	if (!has_vhe())

		__debug_restore_spe_nvhe(vcpu->arch.host_debug_state.pmscr_el1);

		__debug_restore_spe_nvhe(vcpu->arch.host_debug_state.pmscr_el1);





	if (!(vcpu->arch.debug_flags & KVM_ARM64_DEBUG_DIRTY))

	if (!(vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY))

		return;

		return;





	host_ctxt = kern_hyp_va(vcpu->arch.host_cpu_context);

	host_ctxt = kern_hyp_va(vcpu->arch.host_cpu_context);
@@ -196,7 +196,7 @@ void __hyp_text __debug_switch_to_host(struct kvm_vcpu *vcpu) 
	__debug_save_state(vcpu, guest_dbg, guest_ctxt);

	__debug_save_state(vcpu, guest_dbg, guest_ctxt);

	__debug_restore_state(vcpu, host_dbg, host_ctxt);

	__debug_restore_state(vcpu, host_dbg, host_ctxt);





	vcpu->arch.debug_flags &= ~KVM_ARM64_DEBUG_DIRTY;

	vcpu->arch.flags &= ~KVM_ARM64_DEBUG_DIRTY;

}

}





u32 __hyp_text __kvm_get_mdcr_el2(void)

u32 __hyp_text __kvm_get_mdcr_el2(void)

arch/arm64/kvm/hyp/sysreg-sr.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -196,7 +196,7 @@ void __hyp_text __sysreg32_save_state(struct kvm_vcpu *vcpu) 
	sysreg[DACR32_EL2] = read_sysreg(dacr32_el2);

	sysreg[DACR32_EL2] = read_sysreg(dacr32_el2);

	sysreg[IFSR32_EL2] = read_sysreg(ifsr32_el2);

	sysreg[IFSR32_EL2] = read_sysreg(ifsr32_el2);





	if (has_vhe() || vcpu->arch.debug_flags & KVM_ARM64_DEBUG_DIRTY)

	if (has_vhe() || vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY)

		sysreg[DBGVCR32_EL2] = read_sysreg(dbgvcr32_el2);

		sysreg[DBGVCR32_EL2] = read_sysreg(dbgvcr32_el2);

}

}
@@ -218,7 +218,7 @@ void __hyp_text __sysreg32_restore_state(struct kvm_vcpu *vcpu) 
	write_sysreg(sysreg[DACR32_EL2], dacr32_el2);

	write_sysreg(sysreg[DACR32_EL2], dacr32_el2);

	write_sysreg(sysreg[IFSR32_EL2], ifsr32_el2);

	write_sysreg(sysreg[IFSR32_EL2], ifsr32_el2);





	if (has_vhe() || vcpu->arch.debug_flags & KVM_ARM64_DEBUG_DIRTY)

	if (has_vhe() || vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY)

		write_sysreg(sysreg[DBGVCR32_EL2], dbgvcr32_el2);

		write_sysreg(sysreg[DBGVCR32_EL2], dbgvcr32_el2);

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE