Commit fa89a459 authored Dec 19, 2018 by YueHaibing Committed by Steffen Klassert Dec 19, 2018

xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi



gcc warn this:

net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn:
 always true condition '(spi <= 4294967295) => (0-u32max <= u32max)'

'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX
because of wrap around. So the second forloop will never reach.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

parent cc4acb1b

net/ipv6/xfrm6_tunnel.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -144,6 +144,9 @@ static u32 __xfrm6_tunnel_alloc_spi(struct net net, xfrm_address_t saddr)
		index = __xfrm6_tunnel_spi_check(net, spi);
		if (index >= 0)
		goto alloc_spi;

		if (spi == XFRM6_TUNNEL_SPI_MAX)
		break;
		}
		for (spi = XFRM6_TUNNEL_SPI_MIN; spi < xfrm6_tn->spi; spi++) {
		index = __xfrm6_tunnel_spi_check(net, spi);

Admin message