Commit fa809e2f authored Jun 25, 2012 by Eric Dumazet Committed by David S. Miller Jun 25, 2012

ipv6: fib: fix fib dump restart



Commit 2bec5a36 (ipv6: fib: fix crash when changing large fib
while dumping it) introduced ability to restart the dump at tree root,
but failed to skip correctly a count of already dumped entries. Code
didn't match Patrick intent.

We must skip exactly the number of already dumped entries.

Note that like other /proc/net files or netlink producers, we could
still dump some duplicates entries.

Reported-by: Debabrata Banerjee <dbavatar@gmail.com>
Reported-by: Josh Hunt <johunt@akamai.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8b8e4bc0

net/ipv6/ip6_fib.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1349,8 +1349,8 @@ static int fib6_walk_continue(struct fib6_walker_t *w)
		if (w->leaf && fn->fn_flags & RTN_RTINFO) {
		int err;

		if (w->count < w->skip) {
		w->count++;
		if (w->skip) {
		w->skip--;
		continue;
		}

Admin message