Commit fa71f447 authored Aug 08, 2011 by Jeff Layton Committed by Steve French Aug 16, 2011

cifs: demote cERROR in build_path_from_dentry to cFYI



Running the cthon tests on a recent kernel caused this message to pop
occasionally:

    CIFS VFS: did not end path lookup where expected namelen is 0

Some added debugging showed that namelen and dfsplen were both 0 when
this occurred. That means that the read_seqretry returned true.

Assuming that the comment inside the if statement is true, this should
be harmless and just means that we raced with a rename. If that is the
case, then there's no need for alarm and we can demote this to cFYI.

While we're at it, print the dfsplen too so that we can see what
happened here if the message pops during debugging.

Cc: stable@kernel.org
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent b5ddbf46

fs/cifs/dir.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -105,8 +105,8 @@ cifs_bp_rename_retry:
		}
		rcu_read_unlock();
		if (namelen != dfsplen \|\| read_seqretry(&rename_lock, seq)) {
		cERROR(1, "did not end path lookup where expected namelen is %d",
		namelen);
		cFYI(1, "did not end path lookup where expected. namelen=%d "
		"dfsplen=%d", namelen, dfsplen);
		/* presumably this is only possible if racing with a rename
		of one of the parent directories (we can not lock the dentries
		above us to prevent this, but retrying should be harmless) */

Admin message