Commit fa71e952 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: VMX: Use KVM_POSSIBLE_CR*_GUEST_BITS to initialize guest/host masks 



Use the "common" KVM_POSSIBLE_CR*_GUEST_BITS defines to initialize the
CR0/CR4 guest host masks instead of duplicating most of the CR4 mask and
open coding the CR0 mask.  SVM doesn't utilize the masks, i.e. the masks
are effectively VMX specific even if they're not named as such.  This
avoids duplicate code, better documents the guest owned CR0 bit, and
eliminates the need for a build-time assertion to keep VMX and x86
synchronized.

Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20200703040422.31536-3-sean.j.christopherson@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 7c83d096

arch/x86/kvm/vmx/nested.c

+2 −2
Original line number Diff line number Diff line
@@ -4109,7 +4109,7 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu, 
	 * CR0_GUEST_HOST_MASK is already set in the original vmcs01

	 * (KVM doesn't change it);

	 */

	vcpu->arch.cr0_guest_owned_bits = X86_CR0_TS;

	vcpu->arch.cr0_guest_owned_bits = KVM_POSSIBLE_CR0_GUEST_BITS;

	vmx_set_cr0(vcpu, vmcs12->host_cr0);



	/* Same as above - no reason to call set_cr4_guest_host_mask().  */
@@ -4259,7 +4259,7 @@ static void nested_vmx_restore_host_state(struct kvm_vcpu *vcpu) 
	 */

	vmx_set_efer(vcpu, nested_vmx_get_vmcs01_guest_efer(vmx));



	vcpu->arch.cr0_guest_owned_bits = X86_CR0_TS;

	vcpu->arch.cr0_guest_owned_bits = KVM_POSSIBLE_CR0_GUEST_BITS;

	vmx_set_cr0(vcpu, vmcs_readl(CR0_READ_SHADOW));



	vcpu->arch.cr4_guest_owned_bits = ~vmcs_readl(CR4_GUEST_HOST_MASK);

arch/x86/kvm/vmx/vmx.c

+5 −10
Original line number Diff line number Diff line
@@ -133,9 +133,6 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO); 
#define KVM_VM_CR0_ALWAYS_ON				\

	(KVM_VM_CR0_ALWAYS_ON_UNRESTRICTED_GUEST | 	\

	 X86_CR0_WP | X86_CR0_PG | X86_CR0_PE)

#define KVM_CR4_GUEST_OWNED_BITS				      \

	(X86_CR4_PVI | X86_CR4_DE | X86_CR4_PCE | X86_CR4_OSFXSR      \

	 | X86_CR4_OSXMMEXCPT | X86_CR4_LA57 | X86_CR4_TSD)



#define KVM_VM_CR4_ALWAYS_ON_UNRESTRICTED_GUEST X86_CR4_VMXE

#define KVM_PMODE_VM_CR4_ALWAYS_ON (X86_CR4_PAE | X86_CR4_VMXE)
@@ -4034,11 +4031,9 @@ void vmx_set_constant_host_state(struct vcpu_vmx *vmx) 


void set_cr4_guest_host_mask(struct vcpu_vmx *vmx)

{

	BUILD_BUG_ON(KVM_CR4_GUEST_OWNED_BITS & ~KVM_POSSIBLE_CR4_GUEST_BITS);



	vmx->vcpu.arch.cr4_guest_owned_bits = KVM_CR4_GUEST_OWNED_BITS;

	if (enable_ept)

		vmx->vcpu.arch.cr4_guest_owned_bits |= X86_CR4_PGE;

	vmx->vcpu.arch.cr4_guest_owned_bits = KVM_POSSIBLE_CR4_GUEST_BITS;

	if (!enable_ept)

		vmx->vcpu.arch.cr4_guest_owned_bits &= ~X86_CR4_PGE;

	if (is_guest_mode(&vmx->vcpu))

		vmx->vcpu.arch.cr4_guest_owned_bits &=

			~get_vmcs12(&vmx->vcpu)->cr4_guest_host_mask;
@@ -4335,8 +4330,8 @@ static void init_vmcs(struct vcpu_vmx *vmx) 
	/* 22.2.1, 20.8.1 */

	vm_entry_controls_set(vmx, vmx_vmentry_ctrl());



	vmx->vcpu.arch.cr0_guest_owned_bits = X86_CR0_TS;

	vmcs_writel(CR0_GUEST_HOST_MASK, ~X86_CR0_TS);

	vmx->vcpu.arch.cr0_guest_owned_bits = KVM_POSSIBLE_CR0_GUEST_BITS;

	vmcs_writel(CR0_GUEST_HOST_MASK, ~vmx->vcpu.arch.cr0_guest_owned_bits);



	set_cr4_guest_host_mask(vmx);

CRA Git | Maintained and supported by SUSTech CRA and CCSE