Commit fa6f90f3 authored by Joe Perches's avatar Joe Perches Committed by Greg Kroah-Hartman
Browse files

sgi-gru: simplify procfs code some more 



Use seq_puts and simple string output and not seq_printf with formats
and individual strings to reduce overall object size.

$ size drivers/misc/sgi-gru/gruprocfs.o* (x86-64 defconfig with gru)
   text	   data	    bss	    dec	    hex	filename
   7006	      8	      0	   7014	   1b66	drivers/misc/sgi-gru/gruprocfs.o.new
   7472	      8	      0	   7480	   1d38	drivers/misc/sgi-gru/gruprocfs.o.old

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarDimitri Sivanich <sivanich@hpe.com>
Link: https://lore.kernel.org/r/cce61906a5f7f42f5b2b8b947fc61357bcb56e71.camel@perches.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad90ff69

drivers/misc/sgi-gru/gruprocfs.c

+4 −7
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ static int mcs_statistics_show(struct seq_file *s, void *p) 
		"cch_interrupt_sync", "cch_deallocate", "tfh_write_only",

		"tfh_write_restart", "tgh_invalidate"};



	seq_printf(s, "%-20s%12s%12s%12s\n", "#id", "count", "aver-clks", "max-clks");

	seq_puts(s, "#id                        count   aver-clks    max-clks\n");

	for (op = 0; op < mcsop_last; op++) {

		count = atomic_long_read(&mcs_op_statistics[op].count);

		total = atomic_long_read(&mcs_op_statistics[op].total);
@@ -165,8 +165,7 @@ static int cch_seq_show(struct seq_file *file, void *data) 
	const char *mode[] = { "??", "UPM", "INTR", "OS_POLL" };



	if (gid == 0)

		seq_printf(file, "#%5s%5s%6s%7s%9s%6s%8s%8s\n", "gid", "bid",

			   "ctx#", "asid", "pid", "cbrs", "dsbytes", "mode");

		seq_puts(file, "#  gid  bid  ctx#   asid      pid  cbrs dsbytes    mode\n");

	if (gru)

		for (i = 0; i < GRU_NUM_CCH; i++) {

			ts = gru->gs_gts[i];
@@ -191,10 +190,8 @@ static int gru_seq_show(struct seq_file *file, void *data) 
	struct gru_state *gru = GID_TO_GRU(gid);



	if (gid == 0) {

		seq_printf(file, "#%5s%5s%7s%6s%6s%8s%6s%6s\n", "gid", "nid",

			   "ctx", "cbr", "dsr", "ctx", "cbr", "dsr");

		seq_printf(file, "#%5s%5s%7s%6s%6s%8s%6s%6s\n", "", "", "busy",

			   "busy", "busy", "free", "free", "free");

		seq_puts(file, "#  gid  nid    ctx   cbr   dsr     ctx   cbr   dsr\n");

		seq_puts(file, "#             busy  busy  busy    free  free  free\n");

	}

	if (gru) {

		ctxfree = GRU_NUM_CCH - gru->gs_active_contexts;

CRA Git | Maintained and supported by SUSTech CRA and CCSE