Commit fa583f71 authored by Yin Fengwei's avatar Yin Fengwei Committed by Rafael J. Wysocki
Browse files

ACPI: processor_idle: Skip dummy wait if kernel is in guest 



In function acpi_idle_do_entry(), an ioport access is used for
dummy wait to guarantee hardware behavior. But it could trigger
unnecessary VMexit if kernel is running as guest in virtualization
environment.

If it's in virtualization environment, the deeper C state enter
operation (inb()) will trap to hypervisor. It's not needed to do
dummy wait after the inb() call. So we could just remove the
dummy io port access to avoid unnecessary VMexit.

And keep dummy io port access to maintain timing for native
environment.

Signed-off-by: default avatarYin Fengwei <fengwei.yin@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 918c1fe9

drivers/acpi/processor_idle.c

+15 −6
Original line number Diff line number Diff line
@@ -642,6 +642,19 @@ static int acpi_idle_bm_check(void) 
	return bm_status;

}



static void wait_for_freeze(void)

{

#ifdef	CONFIG_X86

	/* No delay is needed if we are in guest */

	if (boot_cpu_has(X86_FEATURE_HYPERVISOR))

		return;

#endif

	/* Dummy wait op - must do something useless after P_LVL2 read

	   because chipsets cannot guarantee that STPCLK# signal

	   gets asserted in time to freeze execution properly. */

	inl(acpi_gbl_FADT.xpm_timer_block.address);

}



/**

 * acpi_idle_do_entry - enter idle state using the appropriate method

 * @cx: cstate data
@@ -658,10 +671,7 @@ static void __cpuidle acpi_idle_do_entry(struct acpi_processor_cx *cx) 
	} else {

		/* IO port based C-state */

		inb(cx->address);

		/* Dummy wait op - must do something useless after P_LVL2 read

		   because chipsets cannot guarantee that STPCLK# signal

		   gets asserted in time to freeze execution properly. */

		inl(acpi_gbl_FADT.xpm_timer_block.address);

		wait_for_freeze();

	}

}
@@ -682,8 +692,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) 
			safe_halt();

		else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) {

			inb(cx->address);

			/* See comment in acpi_idle_do_entry() */

			inl(acpi_gbl_FADT.xpm_timer_block.address);

			wait_for_freeze();

		} else

			return -ENODEV;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE