Commit fa3b5d9a authored May 19, 2010 by Ian Abbott Committed by Greg Kroah-Hartman Jun 17, 2010

Staging: comedi: serial2002: Fix memory leak on detach



The comedi device 'detach' method for the serial2002 driver has an
off-by-one error in its loop for freeing data belonging to its
subdevices.  Fix it.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 9e7f2256

drivers/staging/comedi/drivers/serial2002.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -903,7 +903,7 @@ static int serial2002_detach(struct comedi_device *dev)
		int i;

		printk("comedi%d: serial2002: remove\n", dev->minor);
		for (i = 0; i < 4; i++) {
		for (i = 0; i < 5; i++) {
		s = &dev->subdevices[i];
		if (s->maxdata_list) {
		kfree(s->maxdata_list);

Admin message